refact: cleanup imports.

ruff.toml

@@ -116,7 +116,6 @@ lint.extend-ignore = [
     "SIM117", # Use a single `with` statement with multiple contexts instead of nested `with` statements
     "SLF001", # Private member accessed
     "T201", # `print` found
-    "TID252", # Relative imports from parent modules are banned
     "UP032", # Use f-strings
 ]
 

src/abilian/sbe/apps/calendar/views.py

@@ -10,11 +10,11 @@
 from toolz import groupby
 
 from abilian.i18n import _l
+from abilian.sbe.apps.communities.blueprint import CommunityBlueprint
+from abilian.sbe.apps.communities.views import default_view_kw
 from abilian.web import url_for, views
 from abilian.web.action import ButtonAction
 
-from ..communities.blueprint import CommunityBlueprint
-from ..communities.views import default_view_kw
 from .forms import EventForm
 from .models import Event
 

src/abilian/sbe/apps/documents/webdav/views.py

@@ -13,9 +13,9 @@
 from werkzeug.wrappers import Response
 
 from abilian.core.extensions import db
+from abilian.sbe.apps.documents import repository
 from abilian.services import get_service
 
-from .. import repository
 from .constants import (
     DAV_PROPS,
     HTTP_BAD_REQUEST,

src/abilian/sbe/apps/forum/views.py

@@ -18,16 +18,16 @@
 
 from abilian.core.util import utc_dt
 from abilian.i18n import _, _l
+from abilian.sbe.apps.communities.blueprint import CommunityBlueprint
+from abilian.sbe.apps.communities.common import activity_time_format, object_viewers
 from abilian.sbe.apps.communities.security import is_manager
+from abilian.sbe.apps.communities.views import default_view_kw
 from abilian.services.viewtracker import viewtracker
 from abilian.web import url_for, views
 from abilian.web.action import ButtonAction, Endpoint
 from abilian.web.nav import BreadcrumbItem
 from abilian.web.views import default_view
 
-from ..communities.blueprint import CommunityBlueprint
-from ..communities.common import activity_time_format, object_viewers
-from ..communities.views import default_view_kw
 from .forms import PostEditForm, PostForm, ThreadForm
 from .models import Post, PostAttachment, Thread
 from .tasks import send_post_by_email

src/abilian/sbe/apps/notifications/tasks/social.py

@@ -21,14 +21,13 @@
 from abilian.sbe.apps.documents.models import Document
 from abilian.sbe.apps.documents.repository import content_repository
 from abilian.sbe.apps.forum.models import Post, Thread
+from abilian.sbe.apps.notifications import TOKEN_SERIALIZER_NAME
 from abilian.sbe.apps.wiki.models import WikiPage
 from abilian.services import get_service
 from abilian.services.activity import ActivityEntry
 from abilian.services.auth.views import get_serializer
 from abilian.web import url_for
 
-from .. import TOKEN_SERIALIZER_NAME
-
 
 @crontab("SCHEDULE_SEND_DAILY_SOCIAL_DIGEST")
 @dramatiq.actor()

src/abilian/sbe/apps/notifications/views/social.py

@@ -16,11 +16,14 @@
 from abilian.i18n import render_template_i18n
 from abilian.sbe.apps.communities.security import require_admin
 from abilian.sbe.apps.notifications import TOKEN_SERIALIZER_NAME
+from abilian.sbe.apps.notifications.tasks.social import (
+    make_message,
+    send_daily_social_digest_to,
+)
 from abilian.services import get_service
 from abilian.services.auth.views import get_token_status
 from abilian.services.preferences.service import PreferenceService
 
-from ..tasks.social import make_message, send_daily_social_digest_to
 from . import notifications
 
 __all__ = ()

src/abilian/services/antivirus/service.py

@@ -11,8 +11,7 @@
 from loguru import logger
 
 from abilian.core.models.blob import Blob
-
-from ..base import Service
+from abilian.services.base import Service
 
 try:
     from clamd import ClamdError, ClamdUnixSocket

src/abilian/setup/__init__.py

@@ -13,12 +13,12 @@
 from flask_talisman import DEFAULT_CSP_POLICY, Talisman
 
 from abilian.core import extensions, signals
+from abilian.extensions import asset_manager
 from abilian.services import settings_service
 from abilian.services.security import Anonymous
 from abilian.web.access_blueprint import allow_access_for_roles
 from abilian.web.nav import setup_nav_and_breadcrumbs
 
-from ..extensions import asset_manager
 from .blueprints import setup_blueprints
 from .debug import setup_debug
 from .extensions import init_extensions, init_sentry

src/abilian/web/views/object.py

@@ -19,9 +19,9 @@
 from abilian.i18n import _, _l
 from abilian.services import get_service
 from abilian.services.security import CREATE, DELETE, READ, WRITE
+from abilian.web import csrf, forms, nav
+from abilian.web.action import ButtonAction, Endpoint, actions
 
-from .. import csrf, forms, nav
-from ..action import ButtonAction, Endpoint, actions
 from .base import JSONView, View
 
 

tests/integration/conftest.py

@@ -11,8 +11,7 @@
 from pytest import fixture
 
 from abilian.sbe.app import create_app
-
-from ..conftest import TestConfig
+from tests.conftest import TestConfig
 
 PUBLIC_ENDPOINTS = [
     "login.forgotten_pw_form",

tests/sbe/apps/documents/test_documents.py

@@ -15,8 +15,7 @@
 from abilian.sbe.apps.documents.models import Document, Folder
 from abilian.sbe.apps.documents.views.folders import explore_archive
 from abilian.services import index_service, security_service
-
-from ....util import login, redis_available
+from tests.util import login, redis_available
 
 
 def open_file(filename: str) -> IO[bytes]:

tests/sbe/apps/forum/integration_tests.py

@@ -22,8 +22,8 @@
 from abilian.sbe.apps.forum.views import ThreadCreate
 from abilian.services import get_service, security_service
 from abilian.services.indexing.service import IndexService
+from tests.util import client_login, redis_available
 
-from ....util import client_login, redis_available
 from .util import get_string_from_file
 
 

tests/sbe/apps/wiki/test_models.py

@@ -10,8 +10,7 @@
 
 from abilian.sbe.apps.wiki.markup import SBEWikiLinkExtension
 from abilian.sbe.apps.wiki.models import WikiPage
-
-from ....util import client_login
+from tests.util import client_login
 
 
 @pytest.mark.parametrize("text", ["TOTO", "x 123", "/#$", "/*€("])

tests/services/test_vocabularies.py

@@ -9,8 +9,7 @@
 from abilian.services.vocabularies.models import BaseVocabulary, Vocabulary
 from abilian.services.vocabularies.service import vocabularies
 from abilian.web import url_for
-
-from ..util import path_from_url
+from tests.util import path_from_url
 
 # DefaultVoc = Vocabulary('defaultstates', group='', label='States')
 

tests/web/test_views_registry.py

@@ -15,8 +15,7 @@
 # noinspection PyUnresolvedReferences
 from abilian.web.views import default_view
 from abilian.web.views.registry import Registry
-
-from ..util import class_fqn
+from tests.util import class_fqn
 
 
 class RegEntity(Entity):