Fix arg counting bug in signature help #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old argument counting algorithm was flawed in a few cases, so I rewrote it to just count the number of argument separators between the triggering opcode and the cursor. To account for multi- word opcodes like CHO RDA, the first argument separator is ignored instead of offsetting the arg index, which created the original -1 index bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24
The old argument counting algorithm was flawed in a few cases, so I rewrote it to just count the number of argument separators between the triggering opcode and the cursor. To account for multi- word opcodes like CHO RDA, the first argument separator is ignored instead of offsetting the arg index, which created the original -1 index bug.
I also set
,as a trigger character to get signature help after entering e.g.CHO RDA,(comma with no space).