issue#348. Fixed CSRF tokens not sessioned when using scope and memory_sessions #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tialized only once on server run, not for every handler
aantron
reviewed
Oct 6, 2024
| let sql_sessions = Sql_session.sql_sessions | ||
| let memory_sessions = Session.memory_sessions () | ||
| let cookie_sessions = Session.cookie_sessions () | ||
| let sql_sessions = Sql_session.sql_sessions () |
There was a problem hiding this comment.
At first glance, this looks like whatever is delayed by the extra unit parameter, will be triggered once per process, rather than once per server (or once per scope). With this change, can there be two concurrent uses of two different memory_session middlewares in one process?
| @@ -1583,15 +1583,15 @@ val invalidate_session : request -> unit promise | |||
|
|
|||
| (** {2 Back ends} *) | |||
|
|
|||
| val memory_sessions : ?lifetime:float -> middleware | |||
| val memory_sessions : middleware | |||
There was a problem hiding this comment.
What happened to the ?lifetime parameter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the signature of sessions' functions so that they will be initialized only once on server run, not for every handler. Unfortunately, there's a side effect - session middlewares will be initialized even if they are not used in an application.