fix: cluster-registry-sync-manager nil pointer dereference

aalexandru · Aug 14, 2024 · 12fc352 · 12fc352
1 parent 89bb6fd
commit 12fc352
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/pkg/sync/manager/controller.go b/pkg/sync/manager/controller.go
@@ -325,9 +325,12 @@ func (c *SyncController) hasDifferentHash(object runtime.Object) bool {
 	instance := object.(*registryv1alpha1.ClusterSync)
 
 	oldHash := instance.Status.SyncedDataHash
-	newHash := ptr.To(hash(instance.Status.SyncedData))
 
-	return *oldHash != *newHash
+	if oldHash == nil || instance.Status.SyncedData == nil {
+		return true
+	}
+
+	return *oldHash != hash(instance.Status.SyncedData)
 }
 
 func (c *SyncController) updateStatus(ctx context.Context, instance *registryv1alpha1.ClusterSync) error {