-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transcript trait #477
Transcript trait #477
Conversation
It was just a wrapper with no added meaning.
What used to be called ProofTranscript is now DefaultTranscript. We will make ProofTranscript a type parameter to minimize code changes.
@moodlezoup Would you be able to take a quick look? It'd help before investing effort into fixing the macros and onchain verifier tests. |
67fe454
to
9a3161b
Compare
@moodlezoup this is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit: can we rename DefaultTranscript
to KeccakTranscript
?
Otherwise, looks good to me!
@moodlezoup Done. |
ProofTranscript is now a type parameter everywhere.
This is necessary for in-circuit Jolt verification (Keccak is very expensive in R1CS), also for anyone who might want to use their own transcript implementation.