Transcript trait #477
Merged
Transcript trait #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was just a wrapper with no added meaning.
What used to be called ProofTranscript is now DefaultTranscript. We will make ProofTranscript a type parameter to minimize code changes.
|
@moodlezoup Would you be able to take a quick look? It'd help before investing effort into fixing the macros and onchain verifier tests. |
imikushin
force-pushed
the
transcript-trait
branch
from
67fe454
to
9a3161b
Compare
|
@moodlezoup this is ready for review |
moodlezoup
reviewed
Oct 21, 2024
|
@moodlezoup Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProofTranscript is now a type parameter everywhere.
This is necessary for in-circuit Jolt verification (Keccak is very expensive in R1CS), also for anyone who might want to use their own transcript implementation.