Skip to content

Commit

Permalink
chore(runners): allow default runner configuration
Browse files Browse the repository at this point in the history
  • Loading branch information
j-mendez committed Sep 27, 2023
1 parent 502cf2d commit 54469dd
Show file tree
Hide file tree
Showing 5 changed files with 42 additions and 24 deletions.
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,11 @@ AI_DISABLED=false
CHROME_LB=
FIREFOX_ENABLED=false
PAGEMIND_RECORD=true
DEFAULT_RUNNERS=htmlcs,ace
```

You can set `DEFAULT_RUNNERS` to a comma seperated list with the values of `ace`, `axe`, and `htmlcs`.

## Healthcheck

You can generate a health check client by running `cargo build`. It requires that you first installed the app via `npm i`.
Expand Down
42 changes: 24 additions & 18 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@a11ywatch/pagemind",
"version": "0.9.44",
"version": "0.9.51",
"description": "Get metrics on your web page with inclusion",
"main": "./server.js",
"author": "Jeff Mendez",
Expand Down Expand Up @@ -30,10 +30,10 @@
"@grpc/proto-loader": "0.7.10",
"fastq": "1.15.0",
"get-page-speed": "1.0.1",
"kayle": "0.5.30",
"kayle": "0.7.7",
"lighthouse": "9.6.8",
"pb-util": "1.0.3",
"playwright": "^1.38.0"
"playwright": "^1.38.1"
},
"devDependencies": {
"@swc/core": "^1.3.19",
Expand Down
4 changes: 1 addition & 3 deletions src/core/controllers/update/templates/skip-content.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import type { Issue } from "kayle";

export const skipContentTemplate: Issue = {
export const skipContentTemplate = {
code: "WCAG2A.Principle1.Guideline2.4",
type: "warning",
typeCode: 2,
Expand Down
11 changes: 11 additions & 0 deletions src/core/lib/puppet/page/get-page-issues.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
import { kayle, Audit } from "kayle";
import type { IssueMeta } from "../../../../types";

// const baseRunners = ["htmlcs", "axe"];
// const DEFAULT_RUNNERS = process.env.DEFAULT_RUNNERS
// ? process.env.DEFAULT_RUNNERS.split(",")
// : [];
// const dr = DEFAULT_RUNNERS.length
// ? DEFAULT_RUNNERS.filter((runner) =>
// ["htmlcs", "axe", "ace"].includes(runner)
// )
// : baseRunners;
// const defaultRunners = dr.length ? dr : baseRunners;

export const getPageIssues = async ({
page,
browser,
Expand Down

0 comments on commit 54469dd

Please sign in to comment.