Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure log_dir points to RUN_PATH from .env file #67

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Conversation

chaitjo
Copy link
Collaborator

@chaitjo chaitjo commented Jan 23, 2024

This PR makes a very small change, though I thought its worth opening a PR anyway in order to discuss before merging.

  • There’s an unexpected behaviour with our .env file and logging directory. We ask users to provide a RUN_DIR, which assumes that logs and wandb output will be saved there. However, it seems that the RUN_DIR path is never used in the codebase.
  • What happens instead is that all logs/wandb outputs/etc. are saved to the log_dir variable in the default hydra config for the environment, which always saves things to a /logs folder within the project’s root directory.
  • This PR fixes the above issue.

@amorehead
Copy link
Collaborator

LGTM. What say you, @a-r-j?

@a-r-j
Copy link
Owner

a-r-j commented Jan 23, 2024

LGTM, thanks @chaitjo !

@a-r-j a-r-j merged commit 7d7d1e2 into a-r-j:main Jan 23, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants