Start auto-generating neighbourhood boundaries #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabreegster
commented
Nov 29, 2024
| return; | ||
| } | ||
| try { | ||
| // TODO Waypoints will be missing; editing will not work |
There was a problem hiding this comment.
Will be fixed by switching to the new area drawing tool, which is smart about handling freehand waypoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental start to generating boundaries automatically. It looks for 3 types of severances -- busy roads (based only on highway classification), railways, and bodies of water. Initial results are OK, but plenty of room for later improvement.
There are problems near the edge of the imported study area; we need to preserve more precise import boundaries to fix that.
We also need to prune the results to only include meaningfully neighbourhood-like things -- filtering out small traffic island areas or bits in between dual carriageways, bodies of water, etc. It'll probably depend on both geometric area / extent and semantics of what things border the area. Related to a-b-street/osm2streets#248.