Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update grid for mobile view #38

Merged
merged 2 commits into from
May 27, 2022
Merged

update grid for mobile view #38

merged 2 commits into from
May 27, 2022

Conversation

dingaaling
Copy link
Collaborator

@dingaaling dingaaling commented May 25, 2022 •
edited
Loading

partially addresses #36 and #37

@dingaaling dingaaling requested a review from dabreegster May 25, 2022 12:19
@dabreegster
Copy link
Contributor

I fixed the merge conflicts manually. I tried out Firefox's responsive test mode and things look better:
Screenshot from 2022-05-26 10-33-15

dabreegster
dabreegster approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@dabreegster dabreegster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing things up! After this is deployed, I'll try from my Android. (Firefox's responsive mode is probably sufficient, but still easier to use a real device to see how easy it is to use the carousel)

@dabreegster dabreegster merged commit bfb4695 into main May 27, 2022
@dabreegster dabreegster deleted the grid-updates branch May 27, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabreegster dabreegster dabreegster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dingaaling @dabreegster