Start importing GTFS for São Paulo #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabreegster
commented
Apr 14, 2022
| @@ -529,13 +529,15 @@ fn finish_app_setup( | |||
| } | |||
| } | |||
| Mode::SomethingElse => { | |||
| let start_time = setup.start_time.unwrap_or(Duration::hours(6)); | |||
There was a problem hiding this comment.
Now you can do --dev --time=00:05:42
| if req.start.lane().road == req.end.lane().road | ||
| && req.start.dist_along() > req.end.dist_along() | ||
| { | ||
| bail!( |
There was a problem hiding this comment.
I saw this near a big bus station. Maybe the stops in GTFS were out of order, maybe there was some bug -- for now, just give up on the route
| @@ -158,6 +158,9 @@ impl PathV2 { | |||
| // At the simulation layer, we may need to block intermediate lanes to exit a driveway, | |||
| // so reflect that cost here. The high cost should only be worth it when the v2 path | |||
| // requires that up-front turn from certain lanes. | |||
| // | |||
| // TODO This is only valid if we were leaving from a driveway! This is making some | |||
There was a problem hiding this comment.
This crashes SP center. The pathfinding layer always assumes the start lane can change, which is just super untrue! Need to revisit when I introduced this code and see if I thought about it then.
| self.router.head().get_polyline(map).length() | ||
| }, | ||
| ); | ||
| let end_dist = if self.router.last_step() { |
There was a problem hiding this comment.
More useful error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#372
I really wanted this to be simple, but it turned into some ridiculous yak-shaving to stop the simulation from crashing on the imported routes. I uncovered various bugs with the buses suddenly warping positions, because of the paths between consecutive stops not being built properly. I fixed most (not all) of them. Running the simulation in the city center of SP will crash because of the unfixed one, but Aricanduva and São Miguel Paulista run. No guarantees about the quality of the imported routes; there are likely tons of bugs, but I need to push through this first big change to make smaller progress.