Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG 修复 #123

Merged
merged 3 commits into from
Oct 29, 2023
Merged

BUG 修复 #123

merged 3 commits into from
Oct 29, 2023

Conversation

Hpero4
Copy link
Contributor

@Hpero4 Hpero4 commented Oct 28, 2023

@Hpero4
Copy link
Contributor Author

Hpero4 commented Oct 28, 2023 •
edited
Loading

  1. BUG修复: 在删除软件或修改LOL路径后再次启动软件时, "锁定设置"选项一定会显示为未启用的问题(改为以实际读写权限决定开关状态)

选项卡的初始状态的确存在一些歧义;
如: 您曾经开启过该功能, 重新安装后开关显示是关, 届时在游戏中修改设置是不会被保存的

  1. BUG修复: 在因路径、权限、杀软等原因改写PersistedSettings.json读写权限失败时，弹出提示并将开关状态还原保证逻辑准确。

#121 (comment) 可能存在的问题

@Hpero4 Hpero4 mentioned this pull request Oct 28, 2023
Closed
@Zzaphkiel
Copy link
Owner

感谢 PR！原先锁定设置功能的相关实现方式确实有些不妥，感谢修复~

@Zzaphkiel Zzaphkiel merged commit 556c88f into Zzaphkiel:main Oct 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hpero4 @Zzaphkiel