-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an inventory tab to the shop activity #8
base: master
Are you sure you want to change the base?
Conversation
Deleted some spaces I previously added unvoluntarly.
Why do you copy Heroinfo_Inventory's code into Shopinfo_Inventory, instead of having Shopinfo_Activity extends Heroinfo_Activity ? I could understand "duplicating" some methods, in order to alter behavior (prevent equipment changes for instance), but copying the whole class just seems wrong. You could alter visibility of methods and members in the superclass if needed though (private -> protected). |
I agree with you, but with Heroinfo_Inventory being final, I thought it was better to duplicate. Now HeroinfoActivity_Inventory is no longer final and ShopActivity_Inventory extends it. |
Looks good to me. I'll just need to test it for a while before I merge it in master. |
Added an "Inventory" tab (which is similar to Heroinfo_Inventory) in the shop screen to make the item comparison easier.