Language rework #58

comradekingu · 2018-08-15T13:36:30Z

D-pad, as per https://en.wikipedia.org/wiki/D-pad.
Plate- and chainmail, (to avoid compond word errors), as per https://en.wikipedia.org/wiki/Mail_(armour).

sdevaney · 2018-08-15T14:24:45Z

AndorsTrail/res/values/strings.xml

@@ -183,7 +183,7 @@
 	<string name="about_button2">Authors</string>
 	<string name="about_button3">License</string>
 	<string name="about_contents1">
-		Welcome to Andor\'s Trail, an open-source roguelike RPG on Android.&lt;br /&gt;
+		Welcome to Andor\'s Trail, a copylefted libre roguelike RPG on Android.&lt;br /&gt;


Hmmm I think this wording is confusing. While the actual source code is fully GPL the project as a whole is only partial copyleft at best. Each content creator retains their copyright over their work and whatever license they choose to use with it. We have explicit written approval from the author(s) of the content to use them in this project only.

I agree with @sdevaney. This change is not desirable. Moreover, despite being insufficient, the term of open-source is more widely recognized, and best suited for this high level description.

Zukero

Overall a nice PR. I'd merge this once the "copyleft" one is reverted and the "(requires restart)" changes are consistent.

Zukero · 2018-08-15T14:32:41Z

AndorsTrail/res/values/strings.xml

@@ -654,7 +654,7 @@ Every skill level increases the attack chance of weapons with %1$d %% of their o

 	<string name="preferences_ui_use_localized_resources_title">Use localized resources</string>
 	<string name="preferences_ui_use_localized_resources">Use translation of interface and content, where available. (requires restart)</string>


Missed this one :)

Rijackson · 2018-08-16T20:37:13Z

"The file is created with a newer version than is currently running" should be "The file was created with a newer version than is currently running", since the file was clearly created in the past. Similarly, "Andor's Trail was unable to load the savegame." should be "Andor's Trail is unable to load the savegame.", since the problem is clearly a current one. These errors are not due to the changes made for this PR, but it would be a good time to fix them.

I would also question "Do you want to attack…?". I do not think an ellipsis is correct here. An ellipsis is meant convey missing words, or a lost train of thought, or similar. This is a simple question, and should therefore be just "Do you want to attack?". Again, this is not a result of changes made for this PR, but it would be a good time to address this.

Aside from the ones already noted by sdevaney and Zukero, I agree with all the changes.

comradekingu · 2018-08-17T10:38:11Z

@Rijackson The actual attempt is made in the past, I think one more-so suggests there is no use trying again. Went with standard fare "Could not".

Everything should be in order now.

Rijackson · 2018-08-17T11:34:58Z

Looks good to me :)

Zukero

Getting close :)

Zukero · 2018-08-18T10:56:35Z

AndorsTrail/res/values/strings.xml

@@ -277,12 +277,12 @@

 	<string name="preferences_display_category">Display</string>
 	<string name="preferences_display_fullscreen_title">Fullscreen</string>
-	<string name="preferences_display_fullscreen">Displays the game in fullscreen mode. (Requires restart)</string>
+	<string name="preferences_display_fullscreen">Program restart required to display the game in fullscreen mode.</string>


The fact that it requires a program restart is not the essential fact here. This is the description of the option item. I prefered the previous way, either with parenthesis or as a second sentence.

Zukero · 2018-08-18T10:57:43Z

AndorsTrail/res/values/strings.xml

@@ -653,8 +653,8 @@ Every skill level increases the attack chance of weapons with %1$d %% of their o
 	<!-- Added in v0.7.1 -->

 	<string name="preferences_ui_use_localized_resources_title">Use localized resources</string>
-	<string name="preferences_ui_use_localized_resources">Use translation of interface and content, where available. (requires restart)</string>
-	<string name="change_locale_requires_restart">Changing locale requires restart. Andor\'s Trail has been closed.</string>
+	<string name="preferences_ui_use_localized_resources">Program restart required to use translation of interface and content, where available.</string>


Same for this one. The restart is an indication, not the main information.

Zukero · 2018-08-18T10:59:00Z

AndorsTrail/res/values/strings.xml

-	<string name="preferences_ui_use_localized_resources">Use translation of interface and content, where available. (requires restart)</string>
-	<string name="change_locale_requires_restart">Changing locale requires restart. Andor\'s Trail has been closed.</string>
+	<string name="preferences_ui_use_localized_resources">Program restart required to use translation of interface and content, where available.</string>
+	<string name="change_locale_requires_restart">Program restart required to change language. Andor\'s Trail has been closed.</string>


This is fine, as we explain the player why the app just closed.

Zukero · 2018-08-18T11:00:05Z

AndorsTrail/res/values/strings.xml

@@ -696,11 +696,11 @@ Every skill level increases the attack chance of weapons with %1$d %% of their o
 	<string name="skill_sort_unlocked">Unlocked</string>

 	<string name="preferences_display_theme_title">Theme</string>
-	<string name="preferences_display_theme">Choose the UI theme. (requires restart)</string>
+	<string name="preferences_display_theme">Program restart required to choose UI theme.</string>


Same for this one. The restart is an indication, not the main information.

Zukero · 2018-08-18T11:00:44Z

AndorsTrail/res/values/strings.xml

 	<string name="preferences_display_theme_blue">Cobalt</string>
 	<string name="preferences_display_theme_green">Malachite</string>
 	<string name="preferences_display_theme_charcoal">Obsidian</string>
-	<string name="change_theme_requires_restart">Changing UI theme requires restart. Andor\'s Trail has been closed.</string>
+	<string name="change_theme_requires_restart">Program restart required to change UI theme. Andor\'s Trail has been closed.</string>


This is fine too.

Rijackson

I don't think this addresses the point Zukero made. For example, we had "Displays the game in fullscreen mode. (Requires restart)" The main point is that the user has an option to display the game in fullscreen mode. The fact that it requires a restart is secondary information.

comradekingu · 2018-08-19T17:00:35Z

@Rijackson Made some amends to that effect.

Language rework

177ac75

sdevaney reviewed Aug 15, 2018

View reviewed changes

Zukero requested changes Aug 15, 2018

View reviewed changes

Mistakes reverted, could not, loading.

7778efa

More "restart required"

435b6f6

Zukero requested changes Aug 18, 2018

View reviewed changes

* requires program restart, Localize resources

85db871

Rijackson reviewed Aug 19, 2018

View reviewed changes

, following a program restart

16dd448

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Language rework #58

Language rework #58

comradekingu commented Aug 15, 2018

sdevaney Aug 15, 2018

Zukero Aug 15, 2018

Zukero left a comment

Zukero Aug 15, 2018

Rijackson commented Aug 16, 2018

comradekingu commented Aug 17, 2018

Rijackson commented Aug 17, 2018 •

edited

Loading

Zukero left a comment

Zukero Aug 18, 2018

Zukero Aug 18, 2018

Zukero Aug 18, 2018

Zukero Aug 18, 2018

Zukero Aug 18, 2018

Rijackson left a comment

comradekingu commented Aug 19, 2018

		@@ -654,7 +654,7 @@ Every skill level increases the attack chance of weapons with %1$d %% of their o

		<string name="preferences_ui_use_localized_resources_title">Use localized resources</string>
		<string name="preferences_ui_use_localized_resources">Use translation of interface and content, where available. (requires restart)</string>

Language rework #58

Are you sure you want to change the base?

Language rework #58

Conversation

comradekingu commented Aug 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zukero left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rijackson commented Aug 16, 2018

comradekingu commented Aug 17, 2018

Rijackson commented Aug 17, 2018 • edited Loading

Zukero left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rijackson left a comment

Choose a reason for hiding this comment

comradekingu commented Aug 19, 2018

Rijackson commented Aug 17, 2018 •

edited

Loading