Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

part number update & v1.3 mfgpack release #47

Merged
merged 1 commit into from
Jan 23, 2025
Merged

part number update & v1.3 mfgpack release #47

merged 1 commit into from
Jan 23, 2025

Conversation

Zentrus
Copy link
Contributor

@Zentrus Zentrus commented Jan 15, 2025

NS5B1G385DTT1G is obsolete
74AHC1G66GV,125 is a direct replacement
will update manufacturing pack

Summary by CodeRabbit

  • Documentation

    • Updated README.md with release notes for v1.3
    • Added specific release year and component replacement details
  • Chores

    • Updated component attributes in schematic and board files
    • Replaced part numbers for components IC1 and IC2
    • Updated manufacturer information from ON Semiconductor to Nexperia USA Inc.

NS5B1G385DTT1G is obsolete
74AHC1G66GV,125 is a direct replacement
updated manufacturing pack
@Zentrus Zentrus added the enhancement New feature or request label Jan 15, 2025
@Zentrus Zentrus self-assigned this Jan 15, 2025
Copy link

coderabbitai bot commented Jan 15, 2025

Walkthrough

The pull request involves updating component details across multiple files for two integrated circuits (IC1 and IC2). The changes primarily focus on modifying part numbers, manufacturer information, and supplier details. The README.md file has been updated to reflect the version release for v1.3, while the schematic and board files have been updated with new component attributes from ON Semiconductor to Nexperia USA Inc.

Changes

File Change Summary
README.md - Updated v1.3 release year to 2025
- Added part replacement details
src/babelbabel.brd - Updated IC1 and IC2 attributes:
* Digi-Key part number changed
* LCSC part number updated
* Manufacturer changed to Nexperia USA Inc.
* Manufacturer part number replaced
src/babelbabel.sch - Updated IC1 and IC2 attributes:
* Added Digi-Key part number
* Updated LCSC part number
* Added manufacturer information
* Added manufacturer part number

Poem

🐰 Circuits dancing, parts anew,
Nexperia's magic breaking through
From ON Semi to a brighter stage
Components leap from page to page
A techno-rabbit's upgrade song! 🔧


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (3)
src/babelbabel.brd (1)

4263-4266: Consider supply chain resilience.

Both IC1 and IC2 now use identical parts (74AHC1G66GV,125), which simplifies inventory but could increase supply chain risk. The dual sourcing from both Digi-Key and LCSC helps mitigate this risk.

Consider maintaining a list of additional compatible alternatives in the project documentation for future reference.

README.md (2)

68-69: Maintain consistent list style.

The unordered list items use asterisks (*) while other sections in the document use dashes (-). Consider updating for consistency.

-* Flip the two rest switches.
-* Replaced obsolete part:
+- Flip the two rest switches.
+- Replaced obsolete part:
🧰 Tools
🪛 Markdownlint (0.37.0)

68-68: Expected: dash; Actual: asterisk
Unordered list style

(MD004, ul-style)


69-69: Expected: dash; Actual: asterisk
Unordered list style

(MD004, ul-style)


71-73: Document the part replacement details.

The table clearly documents the part number replacement. However, consider adding:

  1. A brief explanation of why this part is a suitable replacement
  2. Any potential impact on functionality or compatibility
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a19eb7 and 85cfbfb.

📒 Files selected for processing (3)
  • README.md (1 hunks)
  • src/babelbabel.brd (2 hunks)
  • src/babelbabel.sch (2 hunks)
🧰 Additional context used
🪛 Markdownlint (0.37.0)
README.md

68-68: Expected: dash; Actual: asterisk
Unordered list style

(MD004, ul-style)


69-69: Expected: dash; Actual: asterisk
Unordered list style

(MD004, ul-style)

🔇 Additional comments (5)
src/babelbabel.brd (1)

4245-4248: Verify electrical specifications of the replacement part.

While both parts are analog switches in SOT23-5L packages, please verify:

  1. Operating voltage compatibility
  2. On-resistance specifications
  3. Switching time characteristics
  4. Temperature range requirements

Consider updating the documentation to include a note about the compatibility verification performed between NS5B1G385DTT1G and 74AHC1G66GV,125.

✅ Verification successful

Replacement part 74AHC1G66GV,125 is compatible with system requirements

The component meets all system specifications:

  • Operating voltage: Compatible with USB power (4.5-5.5V)
  • Temperature range: Exceeds required 0 to +40°C
  • Package: Maintains SOT23-5L form factor
  • Function: Direct analog switch replacement
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for voltage specifications in schematic files
rg -l "VCC|VDD|power supply" --type txt

# Search for temperature specifications in documentation
fd -e md -e txt -e pdf | xargs rg -l "temperature|thermal|°C"

Length of output: 275


Script:

#!/bin/bash
# Check contents of requirements doc
cat docs/requirements.md

# Find schematic and board files
fd -e sch -e brd

# Search for component references in found files
fd -e sch -e brd -x grep -l "IC1\|IC2\|NS5B1G385\|74AHC1G66"

Length of output: 1579

src/babelbabel.sch (2)

12252-12255: Same deviceset naming concerns apply to IC1.

The same issues regarding deviceset name mismatch and part compatibility verification apply to this component as well.


12240-12243: Verify component compatibility and update deviceset name.

While the attributes have been updated for the new part 74AHC1G66GV,125, the deviceset name still references the old part (NS5B1G385). This mismatch could cause confusion in future maintenance.

Please:

  1. Confirm that the new part 74AHC1G66GV,125 is pin-compatible and electrically equivalent to NS5B1G385DTT1G
  2. Consider updating the deviceset name to match the new part number
README.md (2)

66-66: Verify the release year.

The release year is set to 2025, which is in the future. Please confirm if this is intentional or if it should be set to the current year (2024).


68-68: Clarify the "rest switches" change.

The entry "Flip the two rest switches" lacks context. Consider elaborating on:

  1. Which switches are being referred to
  2. The purpose of flipping them
  3. The impact on functionality
🧰 Tools
🪛 Markdownlint (0.37.0)

68-68: Expected: dash; Actual: asterisk
Unordered list style

(MD004, ul-style)

Comment on lines +4245 to +4248
<attribute name="DIGIKEY#" value="1727-6763-1-ND" x="26.53" y="4.02" size="1.778" layer="27" display="off"/>
<attribute name="LCSC#" value="C554311" x="26.08" y="3.77" size="1.778" layer="27" display="off"/>
<attribute name="MANF" value="Nexperia USA Inc." x="26.53" y="4.02" size="1.778" layer="27" display="off"/>
<attribute name="MANF#" value="74AHC1G66GV,125" x="26.53" y="4.02" size="1.778" layer="27" display="off"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Update component technology definition in schematic file

The schematic file (src/babelbabel.sch) contains inconsistent part references:

  • Component instances correctly use the new part (74AHC1G66GV,125)
  • But the technology definition still references the old part (NS5B1G385DTT1G)

Please update the following attributes in the technology definition:

  • DIGIKEY#: Change from "NS5B1G385DTT1GOSDKR-ND" to "1727-6763-1-ND"
  • MANF: Change from "ON Semiconductor" to "Nexperia USA Inc."
  • MANF#: Change from "NS5B1G385DTT1G" to "74AHC1G66GV,125"
🔗 Analysis chain

Verify consistency across related files.

The component updates look good, but please ensure consistent updates across:

  1. Schematic file (src/babelbabel.sch)
  2. BOM/manufacturing documentation
  3. README.md version history

Also applies to: 4263-4266

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify consistent part numbers across files
rg -l "NS5B1G385|74AHC1G66GV|1727-6763-1-ND|C554311"

# Check for any remaining references to old part
rg "NS5B1G385DTT1G"

Length of output: 344


Script:

#!/bin/bash
# Get context around the old part references in schematic
rg -B 2 -A 2 "NS5B1G385DTT1G" src/babelbabel.sch

# Check for new part number in schematic to see if both exist
rg -B 2 -A 2 "74AHC1G66GV,125" src/babelbabel.sch

Length of output: 898

@Zentrus Zentrus closed this Jan 16, 2025
@Zentrus Zentrus deleted the alternative branch January 16, 2025 09:36
@Zentrus Zentrus restored the alternative branch January 16, 2025 09:37
@Zentrus Zentrus reopened this Jan 16, 2025
@Zentrus Zentrus merged commit 050168c into main Jan 23, 2025
1 check passed
@Zentrus Zentrus deleted the alternative branch January 23, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants