Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate a warning when a default logger is created #168

Merged
merged 1 commit into from
Jan 18, 2025
Merged

generate a warning when a default logger is created #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/logger/methods.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package logger

import (
"context"

"go.uber.org/zap"
)

Expand Down Expand Up @@ -77,7 +78,9 @@ func (l *Logger) IsDebugEnabled() bool {
func GetLoggerFromContext(ctx context.Context) *Logger {
logger, ok := ctx.Value(loggerKey).(*Logger)
if !ok {
return NewLogger()
newLogger := NewLogger()
newLogger.Warnf("Logger had to be created without configuration because the context was missing")
return newLogger
}
return logger
}
Expand Down
Loading