Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve version check with a way to disable the annoying popup. #495

Conversation

leoheck
Copy link
Contributor

@leoheck leoheck commented Jun 4, 2024

This PR also improves the text of the popup and the msg on the report view.

image

This closes the discussion here, #487

@3x380V
Copy link
Contributor

3x380V commented Jun 4, 2024

Hmm, perhaps package also needs to assign freecadmax to prevent it from being even installed on current version ;-)
But seriously, I would welcome if you could give a try to an alternate solution #476 (comment)

@leoheck
Copy link
Contributor Author

leoheck commented Jun 4, 2024

I would welcome if you could give a try to an alternate solution #476 (comment)

I can test it but the solution to what?

@3x380V
Copy link
Contributor

3x380V commented Jun 4, 2024

Solution to the annoying popup (as there is not any).

@leoheck
Copy link
Contributor Author

leoheck commented Jun 6, 2024

Hey @3x380V this your fix looks good for me, better than this popup + not having the LCS working and having to edit it manually one everytime I create a new LCS. Good work, thanks.

@Zolko-123 , please, take some time to check @3x380V solution.

I am going to close this PR since the alternative solution is better.

@leoheck leoheck closed this Jun 6, 2024
@Zolko-123
Copy link
Owner

where can I find @3x380V's solution ? He seems to have simply removed the warning, or is there something else ?

@leoheck
Copy link
Contributor Author

leoheck commented Jun 7, 2024

It is his devel branch, this is a fix for him. The LCSs are being generated fine. I understood that if you would like to have this solution merged you should said so and then he will prepare a better PR for this repo.

He does not need the warning since he has fixed the problem itself which is better.

@3x380V can you please make a PR for us?

@3x380V
Copy link
Contributor

3x380V commented Jun 7, 2024

@leoheck PR is open, a few minor changes I consider useful are waiting in my random_fixes branch. @Zolko-123 is free to cherry-pick or ask for another PR or ignore.

@leoheck
Copy link
Contributor Author

leoheck commented Jun 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants