-update code cleaning

Engine/Common/DataLookupList.cs

@@ -9,6 +9,9 @@ public class DataLookupList
 
         public virtual string GetValue(UInt64 id, string defaultValue = "")
         {
+            if (defaultValue == null)
+                defaultValue = string.Empty;
+
             var res = GetValue(id);
             if (res == "")
             {

Engine/Common/DataLookups.cs

@@ -273,10 +273,10 @@ public bool LoadLookups(string engineId, bool initialLoading = true)
             AllLoadErrors = string.Empty ;
             bool noErrors = true;
             var lookupPath = DefaultLookupPath(engineId);
-            DirectoryInfo DI = new DirectoryInfo(lookupPath);
+            DirectoryInfo di = new DirectoryInfo(lookupPath);
             if (Directory.Exists(lookupPath))
             {
-                foreach (var fi in DI.GetFiles())
+                foreach (var fi in di.GetFiles())
                 {
                     if (!LoadLookupFile(fi.FullName))
                         noErrors = false;
@@ -301,15 +301,14 @@ public DataLookupList NLU(string lookupName,string lookupOffsetString = "")
             */
             if ((lookupOffsetString != string.Empty) && (lookupName.ToLower() == "@math"))
             {
-                if (lookupOffsetString.IndexOf("?") < 0)
+                if (!lookupOffsetString.StartsWith("?"))
                     lookupOffsetString = "? " + lookupOffsetString;
                 MathList.EvalString = lookupOffsetString;
                 return MathList;
             }
             else
             {
-                DataLookupList res;
-                if (LookupLists.TryGetValue(lookupName, out res))
+                if (LookupLists.TryGetValue(lookupName, out var res))
                     return res;
             }
             return NullList;
@@ -344,9 +343,9 @@ public void RegisterCustomLookup(string customListName, UInt64 customId, string
                 return;
             if (customListName.StartsWith("§"))
             {
-                if ((customListName == "§playerid") && (GameViewForm.GV != null))
+                if ((customListName == @"§playerid") && (GameViewForm.GV != null))
                 {
-                    GameViewForm.GV.gbPlayer.Text = "Player 0x" + customId.ToString("X8");
+                    GameViewForm.GV.gbPlayer.Text = @"Player 0x" + customId.ToString("X8");
                     GameViewForm.GV.lPlayerName.Text = customValue;
                 }
                 return;

Engine/Common/EngineBase.cs

@@ -33,21 +33,21 @@ public class EngineBase : IComparable<EngineBase>
         /// <summary>
         /// List of possible Decrypt IDs
         /// </summary>
-        public List<string> DecryptorList { get; } = new List<string>();
+        public virtual List<string> DecryptorList { get; } = new List<string>();
         /// <summary>
         /// List of supported file extension that this engine supports (extension, description)
         /// </summary>
-        public Dictionary<string,string> FileExtensions { get; protected set; }
+        public virtual Dictionary<string,string> FileExtensions { get; protected set; } = new Dictionary<string,string>();
 
         /// <summary>
         /// List containing all data types for this engine to insert (old style)
         /// </summary>
-        public List<string> EditorDataTypes { get; protected set; } = new List<string>();
+        public virtual List<string> EditorDataTypes { get; protected set; } = new List<string>();
 
         /// <summary>
         /// List of names of possible tools that need to be added to the menu 
         /// </summary>
-        public List<string> ToolNamesList { get; protected set; } = new List<string>();
+        public virtual List<string> ToolNamesList { get; protected set; } = new List<string>();
 
         /// <summary>
         /// Lookup Data for this engine
@@ -78,7 +78,6 @@ public static string StripSpacer(string s)
         public EngineBase()
         {
             ParentTab = null;
-            FileExtensions = new Dictionary<string,string>();
         }
 
         /// <summary>
@@ -88,8 +87,6 @@ public EngineBase()
         public EngineBase(PacketTabPage parent)
         {
             ParentTab = parent; // Is set to null in case of registration
-            FileExtensions = new Dictionary<string, string>();
-            // FileExtensions.Add(".txt", "Text File");
         }
 
         /// <summary>
@@ -99,7 +96,7 @@ public EngineBase(PacketTabPage parent)
         /// <returns></returns>
         int IComparable<EngineBase>.CompareTo(EngineBase other)
         {
-            return string.Compare(this.EngineName, other.EngineName);
+            return string.CompareOrdinal(this.EngineName, other.EngineName);
         }
 
         /// <summary>
@@ -128,7 +125,7 @@ public virtual void GetLoadListBoxFlavor(out string text, ref Color color)
         /// </summary>
         public virtual void Init()
         {
-            DataLookups.LoadLookups(EngineId, true);
+            DataLookups.LoadLookups(EngineId);
         }
 
         /// <summary>

Engine/Common/EngineSettingsTab.cs

@@ -1,8 +1,8 @@
-using System;
-using System.Windows.Forms;
+using System.Windows.Forms;
 
 namespace VieweD.Engine.Common
 {
+    // ReSharper disable once ClassWithVirtualMembersNeverInherited.Global
     public class EngineSettingsTab : TabPage
     {
         protected GroupBox panel;
@@ -14,7 +14,7 @@ public EngineSettingsTab(TabControl parent)
             panel = new GroupBox();
             Controls.Add(panel);
             panel.Dock = DockStyle.Fill;
-            panel.Text = " Plugin Settings ";
+            panel.Text = @" Plugin Settings ";
         }
 
         /// <summary>