-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SHA-384, EC point in Jacobi coords and optimize ec_mul_add_fast
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new method `bigint::get_int32` which extracts 32 bit signed integer.
Added new `bigint` methods `to_naf` & `to_rnaf` which converts integer to non-adjacent form (NAF).
Added struct `ec_point_fp_jacobi` which represents EC point in Jacobian coordinates.
Implemented generating KeyPair test cases from rsp file, added additional test cases for `ec_point_fp_jacobi`.
Optimized `ec_mul_add_fast` by implementing reversed NAF scalar multiplication. Refactored `ecdsa_verify` to use `ec_point_fp_jacobi`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ec_point_fp_jacobi
which represents EC point in Jacobian coordinatesec_mul_add_fast
by using reversed NAF methodecdsa_verify
verification times by usingec_point_fp_jacobi
as point types for scalar-point multiplication & additionec_point_fp_jacobi
ec_curve_base::generate_point
andec_curve_fp::generate_point
bigint
methods:to_naf
&to_rnaf
, which converts integer to non-adjacent form (NAF)shake128_fixed
result type