Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements createrawtransaction RPC method #9017

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

elijahhampton
Copy link
Contributor

@elijahhampton elijahhampton commented Nov 13, 2024

Implements createrawtransaction RPC method and parameter validation. Tests to be added in follow-up commit.

Motivation

The goal of this PR is to implement the create_raw_transaction RPC endpoint for zebrad. This will support the effort to fully deprecate zcashd and enhance zcashd with all existing zcashd functionality. This PR will close the following issue: #8952

Specifications & References

Solution

  • Adds createrawtransaction RPC implementation
  • Adds parameter validation for inputs.
  • Adds a test suite for createrawtransaction RPC method (Coming soon)

Tests

  • Test will be added in the follow up commit as this is now a draft.

Follow-up Work

  • There will be no follow up work for this pull request once it is completed.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@elijahhampton elijahhampton marked this pull request as ready for review November 17, 2024 18:52
@elijahhampton elijahhampton requested review from a team as code owners November 17, 2024 18:52
@elijahhampton elijahhampton requested review from upbqdn and removed request for a team November 17, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement createrawtransaction RPC method
1 participant