Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion for "change(rpc): Update getblock RPC to more closely match zcashd" #9008

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Suggestion for "change(rpc): Update getblock RPC to more closely match zcashd" #9008

merged 1 commit into from
Nov 12, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Nov 9, 2024

This is a suggestion PR for @conradoplg with:

  • some minor cleanups,
  • setting a value for the orchardfinalroot field, and
  • removing handling of verbosity = 3 in the getblock method.

@arya2
Removes handling for verbosity = 3 in getblock method, adds finalorch…
fc14525 
…ardroot field, removes unnecessary state request.
@arya2 arya2 self-assigned this Nov 9, 2024
@arya2 arya2 requested a review from a team as a code owner November 9, 2024 01:51
@arya2 arya2 requested review from upbqdn and removed request for a team November 9, 2024 01:51
@arya2 arya2 mentioned this pull request Nov 9, 2024
Open
7 tasks
@arya2 arya2 requested review from conradoplg and removed request for upbqdn November 11, 2024 23:30
conradoplg
conradoplg approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, those are great suggestions!

@conradoplg conradoplg merged commit 349c682 into get-block Nov 12, 2024
138 of 145 checks passed
@conradoplg conradoplg deleted the suggestion-get-block branch November 12, 2024 22:55
@mpguerra mpguerra linked an issue Nov 13, 2024 that may be closed by this pull request
Update getblock RPC method #8446
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradoplg conradoplg conradoplg approved these changes

Assignees

@arya2 arya2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update getblock RPC method
2 participants
@arya2 @conradoplg