-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pub functionality for zaino #8964
Conversation
I'm not sure whether these changes require a CHANGELOG entry? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, i left a minor suggestion for a doc change.
@gustavovalverde is working on a CI issue we have with external pull requests so we can merge this one.
Thanks!
Please let me know if there is anything I can do to help remove the 'Do-Not-Merge' Tag.. |
It was just while we were prepping the release. We should be good to merge now that's out :) |
Hi @idky137 can you update your branch with the last |
Motivation
For Zaino to use Zebra as its backed it requires access to primitives held in Zebra-Chain and Zebra-RPC.
Solution
-Several structs in zebra-rpc were made pub and getter / setter functionality was added.
-From impl was added to ['ConsensusBranchId'] in zebra-chain.
Tests
The most complex functionality added is simple getter / setter impls, I believe that adding new tests for this would be inefficient / redundant.
Follow-up Work
Due to patched libraries in Zebra:main causing issues in Zaino these changes were made atop v1.9.0, once the patches are removed we will update the zebra version to 2.0.0, there is a chance that additional changes will be required for changes in zebra v2.0.0.
PR Author's Checklist
PR Reviewer's Checklist