change(rpc): Avoid re-verifying transactions in blocks if those transactions are in the mempool #8951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want the transaction verifier to avoid re-verifying transactions for the block verifier that have already been verified for the mempool.
This is a draft PR as it still needs tests.
Depends-On: #8857.
Closes #5674.
Solution
transaction_hash
andknown_outpoint_hashes
fields ontransaction::Request::Block
.try_find_verified_unmined_tx()
method on the transaction verifier which queries the mempool for the transaction, then checks that all of its dependencies are present in the set ofknown_outpoint_hashes
.Tests
This PR still needs tests.
PR Author's Checklist
PR Reviewer's Checklist