add(mining): Restore internal miner #8906
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arya2
commented
Oct 2, 2024
arya2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not ready for review (parts of the config and tests still need to be restored, among other issues), and can't be merged until the equihash branch has been merged and published in librustzcash.
One of the changes in this PR is ignoring Zebra's estimated sync status in the
getblocktemplateRPC method, this should be split out into its own PR and made configurable so that Zebra continues to check the estimated sync status before returning block templates by default.There seems to still be a bug in the equihash PR as
Collisionerrors are still occasionally being logged here.Related PRs: