change(consensus): Require that coinbase transactions balance exactly after NU6 activation #8727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructs, splits them into pre/post NU6 funding streams, and adds them as a field on `testnet::Parameters`
…onversion logic with constraints. Minor refactors
…red Testnets, but that being okay since configured testnet parameters are checked when they're being built
…ams, updates the `miner_fees_are_valid()` and `subsidy_is_valid()` functions to check that the deferred pool contribution is valid and that there are no unclaimed block subsidies after NU6 activation, and adds some TODOs
…too, adds Mainnet/Testnet NU6 activation heights, fixes lints/compilation issue
…est_funding_stream_values()` to use a configured testnet with the post-NU6 Mainnet funding streams height range
… as a block submission
arya2
added
A-consensus
arya2
force-pushed
the
coinbase-should-balance-exactly
branch
from
c45fbd4
to
993e915
Compare
7 tasks
…6 height ranges to constants, updates TODO
…tream from `fundingstreams` field
…s instead of an option of an iterator, updates a comment quoting the coinbase transaction balance consensus rule to note that the current code is inconsistent with the protocol spec, adds a TODO for updating the quote there once the protocol spec has been updated.
arya2
force-pushed
the
coinbase-should-balance-exactly
branch
from
993e915
to
935efb9
Compare
arya2
force-pushed
the
coinbase-should-balance-exactly
branch
from
935efb9
to
f308d49
Compare
|
please rebase to get rid of extra commits. thanks! |
upbqdn
approved these changes
Aug 8, 2024
oxarbitrage
approved these changes
Aug 8, 2024
|
@Mergifyio refresh |
✅ Pull request refreshed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to check that coinbase transaction values balance exactly after NU6 activation.
Closes #8696.
Depends-On: #8694.
Specifications & References
https://zips.z.cash/draft-hopwood-coinbase-balance
Solution
block::check::subsidy_is_valid()Tests
Updates an acceptance test to check that blocks are rejected when their coinbase transaction doesn't balance exactly.
PR Author's Checklist
PR Reviewer's Checklist