-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(network-params): Configurable Testnet funding streams #8718
Conversation
077acc2
to
82ccd0b
Compare
5f17a50
to
9a9464c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, i think we can clarify some of the block numbers maybe adding them as constants so we can change them more easy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, also, are the TODOs added supposed to be addressed in a later PR or in this one still?
They're all meant to be addressed in a later PR, the ones related to referencing the final versions of draft ZIPs are meant to be addressed when those draft ZIPs are finalized, the rest are addressed in #8694. |
…tructs, splits them into pre/post NU6 funding streams, and adds them as a field on `testnet::Parameters`
…onversion logic with constraints. Minor refactors
…red Testnets, but that being okay since configured testnet parameters are checked when they're being built
852d634
to
b03e6a2
Compare
b03e6a2
to
7d7f606
Compare
Motivation
We want configurable funding streams to test consensus rule changes in NU6.
Closes #8367.
Depends-On: #8723.
Solution
subsidy.rs
from zebra-consensus to zebra-chainfunding_stream_address_period()
fn to zebra-chainfunding_streams
field ontestnet::Parameters
Related changes:
is_regtest()
after checking the network magic#[serde(deny_unknown_fields)]
on Testnet parameters struct in zebra-network config deserialize implTests
This PR adds a vector test for the constraints on
ParametersBuilder::with_funding_streams()
setter methods and updates the v1.9.0 stored config.PR Author's Checklist
Follow Up Work
Move the
zebra_consensus::block::subsidy
module tozebra-chain
.PR Reviewer's Checklist