Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Address a port conflict issue in the regtest_submit_blocks test #8665

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Jul 8, 2024

Motivation

We want to avoid port conflicts in this test too.

See this comment about the test failing for another PR.

Solution

Uses an OS-assigned port in the regtest_submit_blocks() test's RPC listen_addr and reads it from the logs.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@arya2 arya2 added C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️ labels Jul 8, 2024
@arya2 arya2 self-assigned this Jul 8, 2024
@arya2 arya2 requested a review from a team as a code owner July 8, 2024 22:04
@arya2 arya2 requested review from upbqdn and removed request for a team July 8, 2024 22:04
@mergify mergify bot merged commit 2419e8a into main Jul 8, 2024
132 checks passed
@mergify mergify bot deleted the read-port-from-logs-in-regtest-submit-blocks branch July 8, 2024 23:12
@arya2 arya2 mentioned this pull request Aug 1, 2024
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants