-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): Add missing timeouts to CI and CD tests #7730
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, I've added a |
arya2
previously approved these changes
Oct 11, 2023
teor2345
commented
Oct 16, 2023
arya2
previously approved these changes
Oct 18, 2023
teor2345
force-pushed
the
ci-docker-timeouts
branch
from
October 18, 2023 04:35
4fc0e6e
to
99070b9
Compare
teor2345
changed the title
fix(ci): Add missing timeouts to continous-integration-docker.yml
fix(ci): Add missing timeouts to CI and CD tests
Oct 18, 2023
teor2345
force-pushed
the
ci-docker-timeouts
branch
from
October 18, 2023 08:13
99070b9
to
8a5e4c7
Compare
teor2345
commented
Oct 18, 2023
teor2345
commented
Oct 18, 2023
teor2345
commented
Oct 18, 2023
teor2345
commented
Oct 18, 2023
teor2345
commented
Oct 18, 2023
teor2345
commented
Oct 18, 2023
arya2
approved these changes
Oct 18, 2023
@Mergifyio refresh |
✅ Pull request refreshed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If some CI Docker tests hang, they won't time out for 6 hours. But they never usually take more than 90 minutes.
This means it can be a long time before we see the timeout, which slows down PR fixes (and also other PRs can't use those runners).
Since some runners are custom runners, this also increases our costs.
Depends-On: #7616
Solution
Add 90 minute timeouts to these jobs.
Review
This is a low priority.
@gustavovalverde did you want it to wait until the other refactors merge?
Reviewer Checklist