Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added S_StartSoundAt #2903

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Added S_StartSoundAt #2903

merged 1 commit into from
Jan 18, 2025

Conversation

Boondorl
Copy link
Contributor

Allows for positional sounds that aren't attached to any Actor. Also fixes startTime not being used in S_StartSound.

Allows for positional sounds that aren't attached to any Actor.
@MajorCooke
Copy link
Contributor

Thank you for this. I've been looking forward to someone adding this so now I don't need to add a sound actor whenever spawning a visual thinker. Unless it involves looping sounds but eh. I'll take what I can get!

@Boondorl
Copy link
Contributor Author

Funny enough this actually is directed at VisualThinkers. I've gotten around to using them so expect some more PRs for them in the future.

@madame-rachelle madame-rachelle merged commit a1460e8 into ZDoom:master Jan 18, 2025
9 checks passed
@MajorCooke
Copy link
Contributor

Looking forward to it! Glad to see people like them.

@MajorCooke
Copy link
Contributor

Funny enough this actually is directed at VisualThinkers. I've gotten around to using them so expect some more PRs for them in the future.

By the way, Rachael and I were trying to figure out how to add in sprite rotations but we've been having difficulties. If we put our heads together we might be able to figure something out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants