Streamlined implementation of mGrayCheck and IsGrayed() in option menu items #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jekyllgrim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Updated with 2nd commit) This now adds a streamlined implementation of mGrayCheck and IsGrayed() across Option menu items. Instead of being haphazardly added to different elements, the main field and function is implemented in OptionMenuItem and used across other elements. This also adds graycheck to ScaleSlider, ColorPicker and TextField (the former two didn't have it, and the latter did but in an incomplete form where the element would become unselectable but not actually visibly greyed-out). Hopefully, I didn't miss anything.