Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal Sprite Fix #2323

Closed
wants to merge 1 commit into from
Closed

Portal Sprite Fix #2323

wants to merge 1 commit into from

Conversation

MajorCooke
Copy link
Contributor

Fixed player sprites showing up when crossing portals by disabling interpolation.

NOTE: This is only temporary until I can work out a more permanent solution to the problems with interpolation. Currently, whenever crossing a portal, there's a high chance to show the player sprite, or even the void itself. Which means interpolation only works part of the time with interactive portals.

It's highly immersion breaking and it's bothersome to no end suddenly seeing my player body just popping in out of nowhere. Compared to one tick of no view interpolation, that is much more preferable.

@MajorCooke MajorCooke marked this pull request as draft December 27, 2023 17:26
@MajorCooke
Copy link
Contributor Author

Adjusting for models as well.

@MajorCooke MajorCooke closed this Dec 28, 2023
@MajorCooke MajorCooke deleted the PortalSprite branch December 28, 2023 00:38
@coelckers
Copy link
Member

Disabling the interpolation is not an option for a fix here. This whole nonsense only happens because of the non-linked portals which in hindsight should never have been left as they are.
Maybe it's enough to set a flag that checks if the map has such portals and only then tries to do some workarounds. In cases where there's only linked portals the player sprite can just be left disabled like it is normally.

@MajorCooke
Copy link
Contributor Author

MajorCooke commented Dec 28, 2023

I closed it because I have a better way incoming but I'll keep that in mind.

@MajorCooke
Copy link
Contributor Author

Also keep in mind this problem happens with sector portals too. Not just line portals. Static checks won't cut it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants