Added CollidedWith virtual for Actors #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guarantees a collision happened unlike CanCollideWith. Called in TryMove so it only calls when an actual movement was attempted and not just a potential positional check.
|
Very much would be appreciated. Just a heads up though, it's failing to build on Linux CI. |
This is likely a side effect of basing the work on a time when the filesystem was still being refactored. Rebasing it on current master (or waiting until the FS work is completely done to do that) might be enough to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guarantees a collision happened unlike CanCollideWith. Called in P_TryMove and P_CheckOnmobj so it only calls when an actual movement was attempted and not just a potential positional check. Also not called while the player is predicting to avoid having to manage it on the ZScript side. As a special note, this function is intentionally called before the collider is repositioned after a failed movement. This is so modders can get the exact position of the collision.