Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZSprites #2197

Merged
merged 6 commits into from
Nov 17, 2023
Merged

ZSprites #2197

merged 6 commits into from
Nov 17, 2023

Conversation

MajorCooke
Copy link
Contributor

The first base thinker class capable of rendering out graphics without being a thinker.

Big thanks to Ricardo, PhantomBeta and RaveYard for helping me make this a reality.

Testing package

Two actors for summoning: emit (standard emitter) and spri (offset testing)

@MajorCooke MajorCooke marked this pull request as draft October 2, 2023 22:34
@MajorCooke MajorCooke marked this pull request as ready for review October 3, 2023 00:00
@RicardoLuis0
Copy link
Collaborator

this is all i've spotted on a first look, but i might've missed something

@inkoalawetrust
Copy link
Contributor

Are there any issues left with this ?

@MajorCooke
Copy link
Contributor Author

Aside from the merge conflict, not from what I've seen, no. I'll work on fixing that now.

@MajorCooke
Copy link
Contributor Author

Alright, this is all caught up.

- Effectively similar to Actors, but without the excess.
- Can be created with either the `level` function or the static `Spawn` function in ZSprite.
- STAT_SPRITE belongs to ZSprites only; ZSprites cannot be moved out of, nor can anything else be moved in to, this statnum.

Misc:

- Fixed (Sprite)Offset taking roll into account.

Crediting phantombeta, RicardoLuis0 and RaveYard for assistance.
- fixed ZSprites not updating important variables while frozen.
- Added `Construct()` method and ensure it's called when created from any means
@madame-rachelle madame-rachelle merged commit 1f84730 into ZDoom:master Nov 17, 2023
10 checks passed
@MajorCooke MajorCooke deleted the ZSprite branch October 27, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants