Add support for PublicKeyCredentialHint #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdennis
force-pushed
the
publicKeyCredentialHint
branch
from
cab8c13
to
28bcbb0
Compare
These are already implied by the `@Value` Lombok annotation - the explicit modifier probably appeared when we used delombok to generate the new constructors. (Most) other classes in the repo don't have the explicit `final` modifier, so let's leave it out here too so it doesn't seem like these classes are different.
Test Results2 230 tests 2 222 ✅ 1m 14s ⏱️ Results for commit 7694886. ♻️ This comment has been updated with latest results. |
…d PublicKeyCredentialHint...
The reason we couldn't do this previously is that we were setting `hints` to `null` in the `PublicKeyCredentialRequestOptions` generator. We no longer do since commit 89e78ff, so we can now require this to be non-null.
hertg
reviewed
Sep 6, 2024
webauthn-server-core/src/test/scala/com/yubico/webauthn/RelyingPartyStartOperationSpec.scala
Show resolved
Hide resolved
emlun
force-pushed
the
publicKeyCredentialHint
branch
from
477f4c3
to
7694886
Compare
emlun
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #371.