icemulti: Re-use images #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fourth part of the changes suggested in pull request #90. It causes
icemultito include input files listed on the command line only once in the output file, regardless of whether they have been specified explicitly by file name or implicitly using-p/ as default.Up to now,
icemultiincluded the input files listed on the command line exactly in that order in the output file. The power-on/reset header and, if less than four input files have been specified, the remaining headers point to the input file to be used on power-on/reset (usually the first one).Normally, the input files are different from each other, so this is not an issue. However, once specifying a default and a power-on/reset input file by its file name rather than index will be implemented, this will cause an inconsistency. It would be counter-intuitive to the user if different ways of specifying the input files would result in different outputs. Also, there is no reason why listing an input file multiple times on the command line should produce a different output than omitting it and having it used as default.
This pull request contains a series of commits which refactor
icemultiin a way which makes this change possible. In addition, it prints the now stored image filenames along with the offsets if offset printing has been requested on the command line.