refactor: use styled-system v5 #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw0517tw
approved these changes
Feb 4, 2020
jigsawye
force-pushed
the
refactor/styled-system-v5
branch
2 times, most recently
from
6b5b33a to
928d7a8
Compare
jigsawye
commented
Feb 5, 2020
| toRem(768), | ||
| toRem(992), | ||
| toRem(1200), | ||
| ]; |
There was a problem hiding this comment.
https://github.com/styled-system/styled-system/blob/master/packages/core/src/index.js#L62
因為 v5 新增了 cache breakpoints 的功能，但他們實作上只支援 array
所以這邊把 sm / md / lg / xl 的 alias 拿掉了
There was a problem hiding this comment.
這樣對tailor ui 來說是 breaking change QQ?
jigsawye
commented
Feb 5, 2020
| <Radio value="en_US">English</Radio> | ||
| <Radio value="zh_Hant">正體中文</Radio> | ||
| </RadioGroup> | ||
|
|
||
| <Box mt="3"> | ||
| <UIProvider locale={locales[value]}> |
There was a problem hiding this comment.
改成使用全域的 UIProvider 避免多個 Provider 打架
kpman
reviewed
Feb 5, 2020
docs/UIProvider.md
Outdated
| const [visible, setVisible] = useState(false); | ||
| const modal = useModal(); | ||
|
|
||
| return ( | ||
| <> | ||
| <RadioGroup value={value} onChange={setValue}> | ||
| <RadioGroup value={locale} onChange={newLocale => setLocale(newLocale)}> |
There was a problem hiding this comment.
這個不能直接傳 setLocale 嗎？ onChange={setLocale}
kpman
reviewed
Feb 5, 2020
| xl: string; | ||
| } | ||
| string | ||
| ]; |
jigsawye
force-pushed
the
refactor/styled-system-v5
branch
from
928d7a8 to
eabe01d
Compare
kpman
reviewed
Feb 5, 2020
| JustifyContentProps; | ||
|
|
||
| const flex = compose(box, alignItems, flexDirection, justifyContent, flexWrap); | ||
| export type FlexProps = BoxProps; |
There was a problem hiding this comment.
v5 把一些相關的 API 整合在一起，詳見：https://styled-system.com/table
kpman
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #416
之前的 breaking 好像消失了，穩穩升