Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TelInput): add FormField in TelInput, ref: #311 #373

Merged
merged 1 commit into from
Dec 13, 2019
Merged

feat(TelInput): add FormField in TelInput, ref: #311 #373

merged 1 commit into from
Dec 13, 2019

Conversation

neighborhood999
Copy link

螢幕快照 2019-12-12 下午3 40 57

@jigsawye
Copy link
Collaborator

TelInput.md 裡需要加個 example
PR 可以寫個 related #311

@neighborhood999 neighborhood999 force-pushed the feat/tel-input-with-form-field branch from 54502a1 to f0c4bba Compare December 12, 2019 08:02
@neighborhood999 neighborhood999 changed the title feat(TelInput): add FormField in TelInput feat(TelInput): add FormField in TelInput, ref: #311 Dec 12, 2019
jigsawye
jigsawye requested changes Dec 12, 2019
View reviewed changes
Copy link
Collaborator

@jigsawye jigsawye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前這樣無法在 validationMessage or validator 拿到 onChange value 做處理

packages/tailor-ui/src/TelInput/TelInput.tsx Outdated Show resolved Hide resolved
packages/tailor-ui/src/TelInput/TelInput.tsx Outdated Show resolved Hide resolved
@neighborhood999 neighborhood999 force-pushed the feat/tel-input-with-form-field branch from f0c4bba to 24a61c8 Compare December 12, 2019 09:45
@neighborhood999 neighborhood999 force-pushed the feat/tel-input-with-form-field branch from 24a61c8 to e089def Compare December 12, 2019 13:06
@neighborhood999 neighborhood999 force-pushed the feat/tel-input-with-form-field branch from e089def to 8f3d907 Compare December 13, 2019 03:23
@jigsawye jigsawye merged commit 783dab0 into master Dec 13, 2019
@jigsawye jigsawye deleted the feat/tel-input-with-form-field branch December 13, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jigsawye jigsawye jigsawye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neighborhood999 @jigsawye