New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal][Doc] 加一頁介紹 system-props #416

Open

homerchen19 opened this issue Feb 3, 2020 · 1 comment

Collaborator

homerchen19 commented Feb 3, 2020

看目前 doc 好像都沒有介紹到 styled-system，所以覺得如果加上這頁 https://primer.style/components/system-props 簡單介紹，還有在每個 component 頁列出這個 component 能用哪些種類的 props，那會很讚

Collaborator

jigsawye commented Feb 3, 2020

這可以有，只是可能要 upgrade 一下 styled-system
目前 codebase 是 v4 最新是 v5，
主要是因為多了 size 這個 props 跟我們原本有用到的 size 打架了才沒有升

jigsawye mentioned this issue

refactor: use styled-system v5 #422

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment