Skip to content

Commit

Permalink
Update docs
Browse files Browse the repository at this point in the history
  • Loading branch information
YanWenKun committed Dec 14, 2024
1 parent 00c0df5 commit 341ec8c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
10 changes: 6 additions & 4 deletions README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,14 @@ Previous releases will remain unchanged.

== Features

* Pre-installed with 40+ frequently-used custom nodes. <<custom-nodes, [Full list]>>
* Pre-installed with 40+ commonly-used custom nodes. <<custom-nodes, [Full list]>>

** With all the model files that need to be downloaded on the first run (which may cause freezing for users with a poor Internet Connection).

* Includes 240+ Python packages, versions compatible, including:
** Packages like `insightface`, `dlib` and `CLIP` that require compilation.
* Includes 240+ mutually compatible Python packages, including:

** `insightface`, `dlib`, etc., which require compilation during installation.

** xFormers, which is not included in the ComfyUI official package for an understandable reason. It may not be significant for text-to-image, but could be useful for video workflows.

* Only a few functional models that might slow down the program startup are pre-installed; users please prepare SD models of your favorite.
Expand Down Expand Up @@ -278,7 +280,7 @@ However, the packaging concept is similar: providing a self-contained, portable,

The difference is that I didn't download wheels first and then install them in bulk like Comfy did. Because dependency relationships are too tricky, I went straight to `pip install` for dependency solving.

To add a memo, a common issue with Python Embedded in such pre-installed packages is that most of the executables in the `Scripts` directory cannot run properly. This is because these executables are often Python command wrappers that invoke `python.exe` through an absolute path. Once the directory changes (or is relocated), they naturally fail to execute. Fortunately, this does not affect the current project significantly."
As a note, a common issue with Python Embedded in such pre-installed packages is that most of the executables in the `Scripts` directory cannot run properly. This is because these executables are often Python command wrappers that invoke `python.exe` through an absolute path. Once the directory changes (or is relocated), they naturally fail to execute. Fortunately, this does not affect the current project significantly.


== See Also
Expand Down
2 changes: 1 addition & 1 deletion README.zh.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ https://github.com/ltdrdata/ComfyUI-Impact-Pack[Impact Pack]
会在初次启动时下载的模型文件等,避免国内用户启动时卡下载。

* 包含 240+ 互相兼容的 Python 包,包括:
** 需要编译安装的 `insightface`、`dlib`、`CLIP`
** 需要编译安装的 `insightface`、`dlib` 等
** ComfyUI 官方包里没装的 xFormers(对文生图影响不大,对视频类有用)

* 仅预置了少量功能性模型,绘图模型还请用户自行下载
Expand Down

0 comments on commit 341ec8c

Please sign in to comment.