Build wheels in docker container #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifield
requested review from
jackl-xilinx,
jgmelber and
stephenneuendorffer
as code owners
|
I triggered the workflow manually and tested the wheel on ubuntu 24 hawkpoint using the quick_setup instructions. It seemed to work. https://github.com/Xilinx/mlir-aie/actions/runs/11503835543 |
jgmelber
approved these changes
Oct 24, 2024
|
Agreed. These are all great reasons to switch from running this on Ryzen AI runners |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the buildRyzenWheels workflow to run in docker container. This is so that the action can run on general purpose runners instead of on the Ryzen AI runners. It is slower, but this workflow does not need to be fast and the Ryzen AI runners are a limited resource. This PR also updates the build to use Vitis AIE Essentials instead of Vitis 2023.2 so that AIE2P is better supported.