xrt-smi re-architecture patch 2 : Config Integration with xrt-smi examine #8696
+121
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akshay Tondak <[email protected]>
aktondak
requested review from
rozumx,
chvamshi-xilinx and
AShivangi
as code owners
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
This PR is the next step to #8656.
It adds the config based option addition to xrt-smi examine. This PR also augments the configuration for examine with options' field populated.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
https://jira.xilinx.com/browse/VITIS-13903
How problem was solved, alternative solutions (if any) and why they were rejected
The problem was solved by removing option addition calls in SubCmdExamineInternal constructors and relying on config schema to add options.
Risks (if any) associated the changes in the commit
XRT-SMI should be tested after this change.
What has been tested and how, request additional testing if necessary
tested on Linux and windows platforms.
Documentation impact (if any)
None