Prep for building separate packages for base, npu, and alveo #8691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support breaking XRT build into base, npu, and alveo packages with separate packages for deployment and development. Define CMake components for legacy xrt, new base, and for npu. Add conditional CMake flags for enabling / disabling parts of the code base depending on what component is built. Add build.sh switches for building base and npu packages. By default `build.sh` continues to build legacy packages with no changes to content. Specifying `build.sh -base` builds base deployment and development packages. For the time being (as this is work-in-progress) everything not explicitly excluded when building for `base` component will be dumped into the base packages. Specifying `build.sh -npu` builds a single npu package containing both deployment and development. For the time being (as this is work-in-progress) everything not explicitly excluded with building for `npu` component will be dumped into the npu package. E.g., preserves the current behavior. No changes have been made to how aiebu submodule is built; changes will follow later as the components built for aiebu are incorrectly named. Also, it's TBD if aiebu should be included in appropriate XRT component (npu and maybe alveo). Signed-off-by: Soren Soe <[email protected]>
Remove all xrt-dev-targets exports and consolidate install targets to modern syntax. Signed-off-by: Soren Soe <[email protected]>
stsoe
requested review from
rozumx,
sonals,
chvamshi-xilinx,
uday610 and
AShivangi
as code owners
By defaulting to legacy XRT build, we don't have to change windows build scripts right now. Signed-off-by: Soren Soe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Support breaking XRT build into base, npu, and alveo packages with
separate packages for deployment and development. Still work-in-progress.
How problem was solved, alternative solutions (if any) and why they were rejected
Define CMake components for legacy xrt, new base, and for npu. Add
conditional CMake flags for enabling / disabling parts of the code
base depending on what component is built.
Add build.sh switches for building base and npu packages.
By default
build.shcontinues to build legacy packages with nochanges to content.
Specifying
build.sh -basebuilds base deployment and developmentpackages. For the time being (as this is work-in-progress) everything
not explicitly excluded when building for
basecomponent will bedumped into the base packages.
Specifying
build.sh -npubuilds a single npu package containing bothdeployment and development. For the time being (as this is
work-in-progress) everything not explicitly excluded with building for
npucomponent will be dumped into the npu package. E.g., preservesthe current behavior.
No changes have been made to how aiebu submodule is built; changes
will follow later as the components built for aiebu are incorrectly
named. Also, it's TBD if aiebu should be included in appropriate XRT
component (npu and maybe alveo).
For time being, windows build22.bat was changed to build legacy XRT
no changes. Later windows builds will be updated to support base and
npu along with deployment and development (SDK).
Risks (if any) associated the changes in the commit
Edge unknown
What has been tested and how, request additional testing if necessary
Build with
build.sh -optfollowed by comparing content of all component packages.