Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Xilinx/XRT] [XDP] Initial support for profiling and tracing microcontrollers on VE2 #8689

Merged
merged 51 commits into from
Jan 14, 2025
Merged

[Xilinx/XRT] [XDP] Initial support for profiling and tracing microcontrollers on VE2 #8689

merged 51 commits into from
Jan 14, 2025

Conversation

pgschuey
Copy link
Collaborator

@pgschuey pgschuey commented Jan 11, 2025 •
edited
Loading

Problem solved by the commit

  • Support was needed to profile and trace the microcontrollers on VE2 devices
  • With the addition of device-specific implementations in plugins, code needed to be re-architected to reduce redundant code
  • Client build was broken as 16-bit versions of driver APIs are not available

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

  • Accommodates recent changes in driver from 8b to 16b

How problem was solved, alternative solutions (if any) and why they were rejected

  • Locations of microcontrollers were identified and metric sets were added to the VE2-specific implementation
  • Common functions in plugin implementations were moved to common area

Risks (if any) associated the changes in the commit

  • A lot of code was moved around, so continued testing is needed, especially for profile API work (i.e., latency, start to bytes).
  • Changes conflict with PR-8692. I requested that one wait for this PR to be merged first.

What has been tested and how, request additional testing if necessary

  • Began testing microcontrollers on VE2
  • Profile and trace on vek280
  • Builds on client

Documentation impact (if any)

  • Supported metric sets for VE2

Paul Schumacher and others added 20 commits January 3, 2025 17:03
initial profile/trace support for VE2
4f24e86 
Signed-off-by: Paul Schumacher <[email protected]>
corrections to new branch
9c9799d 
Signed-off-by: Paul Schumacher <[email protected]>
more corrections to new branch
392d78e 
Signed-off-by: Paul Schumacher <[email protected]>
removing unnecessary code change
871dac7 
Signed-off-by: Paul Schumacher <[email protected]>
moved API and corrected bugs in profiling
eb80593 
Signed-off-by: Paul Schumacher <[email protected]>
modified comment
577e116 
Signed-off-by: Paul Schumacher <[email protected]>
merge with master
501445d 
Signed-off-by: Paul Schumacher <[email protected]>
modified another comment
e579f76 
Signed-off-by: Paul Schumacher <[email protected]>
removed duplicate function and fixed MDM related bug
941679f 
Signed-off-by: Paul Schumacher <[email protected]>
made 8b to 16b event change
74cdd29 
Signed-off-by: Paul Schumacher <[email protected]>
fixed bug when getting uCs
e29ca54 
Signed-off-by: Paul Schumacher <[email protected]>
client side corrections
f3f6e5d 
Signed-off-by: Paul Schumacher <[email protected]>
fixed edge compile error
aa84fa8 
Signed-off-by: Paul Schumacher <[email protected]>
fixed some _16 API issues on client
fa682e2 
Signed-off-by: Paul Schumacher <[email protected]>
commented out undefined metrics
802e852 
Signed-off-by: Paul Schumacher <[email protected]>
updated module type for uCs
d38aba3 
Signed-off-by: Paul Schumacher <[email protected]>
more client side fixes
976c605 
Signed-off-by: Paul Schumacher <[email protected]>
removed unnecessary header
56e87d1 
Signed-off-by: Paul Schumacher <[email protected]>
fixed bug in mem tile event call
6faa525 
Signed-off-by: Paul Schumacher <[email protected]>
@vipangul
Build fix by moving functions to util
758649e 
Signed-off-by: Vinod Pangul <[email protected]>
@pgschuey pgschuey requested review from vipangul and parthash0804 and removed request for stsoe, rozumx and jvillarre January 11, 2025 16:03
@pgschuey pgschuey marked this pull request as draft January 11, 2025 16:03
@chvamshi-xilinx
Revert "Modified the aie-rt function APIs and updated the datatype of…
fea370d 
… its parameter from u8 to u16" (Xilinx#8690)

* Revert "Modified the aie-rt function APIs and updated the datatype of its par…"

This reverts commit 2b36d6a.

* Update petalinux.build
Paul Schumacher and others added 16 commits January 13, 2025 17:07
moved API and corrected bugs in profiling
6911107 
Signed-off-by: Paul Schumacher <[email protected]>
modified comment
9a17eae 
Signed-off-by: Paul Schumacher <[email protected]>
modified another comment
5a5ecb2 
Signed-off-by: Paul Schumacher <[email protected]>
removed duplicate function and fixed MDM related bug
6c341ac 
Signed-off-by: Paul Schumacher <[email protected]>
made 8b to 16b event change
b957ef1 
Signed-off-by: Paul Schumacher <[email protected]>
fixed bug when getting uCs
05dfbd2 
Signed-off-by: Paul Schumacher <[email protected]>
client side corrections
30baccf 
Signed-off-by: Paul Schumacher <[email protected]>
fixed edge compile error
fa007eb 
Signed-off-by: Paul Schumacher <[email protected]>
fixed some _16 API issues on client
e3a78e1 
Signed-off-by: Paul Schumacher <[email protected]>
commented out undefined metrics
560ecd0 
Signed-off-by: Paul Schumacher <[email protected]>
updated module type for uCs
89e04e5 
Signed-off-by: Paul Schumacher <[email protected]>
more client side fixes
7005a0f 
Signed-off-by: Paul Schumacher <[email protected]>
removed unnecessary header
44f13bf 
Signed-off-by: Paul Schumacher <[email protected]>
fixed bug in mem tile event call
2140114 
Signed-off-by: Paul Schumacher <[email protected]>
@vipangul
Build fix by moving functions to util
c1b220c 
Signed-off-by: Vinod Pangul <[email protected]>
reverted using _16 APIs
92688a6 
Signed-off-by: Paul Schumacher <[email protected]>
@pgschuey pgschuey changed the title Initial support for profiling and tracing microcontrollers on VE2 [Xilinx/XRT] [XDP] Initial support for profiling and tracing microcontrollers on VE2 Jan 13, 2025
Paul Schumacher added 5 commits January 13, 2025 22:49
@pgschuey pgschuey marked this pull request as ready for review January 14, 2025 15:58
Paul Schumacher added 4 commits January 14, 2025 16:17
fixing compilation issues on native x86
0f3b99b 
Signed-off-by: Paul Schumacher <[email protected]>
removed unnecessary changes
69adc0e 
Signed-off-by: Paul Schumacher <[email protected]>
added enable_multi_layer back in
063b014 
Signed-off-by: Paul Schumacher <[email protected]>
removed dependency on util in metadata
53c5786 
Signed-off-by: Paul Schumacher <[email protected]>
@pgschuey pgschuey requested a review from jvillarre January 14, 2025 21:20
@jvillarre jvillarre merged commit 40eee0e into Xilinx:master Jan 14, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvillarre jvillarre jvillarre approved these changes

@vipangul vipangul Awaiting requested review from vipangul

@parthash0804 parthash0804 Awaiting requested review from parthash0804

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgschuey @jvillarre @vipangul @chvamshi-xilinx