Windows build fix from the previous commit of graph task #8301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SravanKumarAllu-xilinx
requested review from
chvamshi-xilinx and
stsoe
and removed request for
stsoe and
rozumx
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
windows build issues in XRT
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Below PR of graph task caused the windows build issues and identified through local windows build
#8292
How problem was solved, alternative solutions (if any) and why they were rejected
Removed unused parameters in virtual functions which not using those parameters.
Risks (if any) associated the changes in the commit
N/A
What has been tested and how, request additional testing if necessary
Local windows build is successful.
Documentation impact (if any)
N/A