Address review comment

Signed-off-by: Eddie Hung <[email protected]>
Xilinx · Jun 13, 2024 · e785302 · e785302
1 parent ad8d152
commit e785302
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/com/xilinx/rapidwright/interchange/DeviceResourcesWriter.java b/src/com/xilinx/rapidwright/interchange/DeviceResourcesWriter.java
@@ -117,6 +117,8 @@ public class DeviceResourcesWriter {
     private static DelayEstimatorBase delayEstimator;
     private static DelayModel intrasiteAndLogicDelayModel;
 
+    private static final float ONE_PICOSECOND = 1e-12f;
+
     public static void populateSiteEnumerations(SiteInst siteInst, Site site) {
         if (!siteTypes.containsKey(siteInst.getSiteTypeEnum())) {
             if (site.getSiteTypeEnum() != siteInst.getSiteTypeEnum()) {
@@ -662,7 +664,7 @@ public static void writeAllSiteTypesToBuilder(Design design, Device device, Devi
                     if (delayPs != null && delayPs > 0) {
                         DeviceResources.Device.CornerModel.Builder delayBuilder = spBuilder.initDelay();
                         DeviceResources.Device.CornerModelValues.Builder slowBuilder = delayBuilder.initSlow().initSlow();
-                        slowBuilder.initMax().setMax(delayPs * 1e-12f);
+                        slowBuilder.initMax().setMax(delayPs * ONE_PICOSECOND);
                     }
                 }
             }
@@ -855,7 +857,7 @@ public static Map<TileTypeEnum, Integer> writeAllTileTypesToBuilder(Design desig
             DeviceResources.Device.PIPTiming.Builder timingBuilder = pipTimingsBuilder.get(index);
             DeviceResources.Device.CornerModel.Builder delayBuilder = timingBuilder.initInternalDelay();
             DeviceResources.Device.CornerModelValues.Builder slowBuilder = delayBuilder.initSlow().initSlow();
-            slowBuilder.initMax().setMax(slowMaxDelayPs * 1e-12f);
+            slowBuilder.initMax().setMax(slowMaxDelayPs * ONE_PICOSECOND);
         }
 
         return tileTypeIndicies;
@@ -961,7 +963,7 @@ public static void writeAllWiresAndNodesToBuilder(Device device, DeviceResources
             DeviceResources.Device.CornerModelValues.Builder resBuilder = timingBuilder.initResistance().initSlow().initSlow();
             resBuilder.initMax().setMax(slowMaxDelayPs);
             DeviceResources.Device.CornerModelValues.Builder capBuilder = timingBuilder.initCapacitance().initSlow().initSlow();
-            capBuilder.initMax().setMax(1e-12f);
+            capBuilder.initMax().setMax(ONE_PICOSECOND);
         }
     }
     private static void populatePackages(StringEnumerator allStrings, Device device, DeviceResources.Device.Builder devBuilder) {