-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich wires #523
Rich wires #523
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #523 +/- ##
===========================================
- Coverage 90.20% 90.19% -0.02%
===========================================
Files 102 102
Lines 6321 6314 -7
===========================================
- Hits 5702 5695 -7
Misses 619 619
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job Filippo!
Wires have been challenging to maintain due to evolving requirements.
This PR introduces a better abstraction for Wire that stores a collection of
QuantumWire
andClassicalWire
dataclasses. Metadata can be added to these dataclasses without modifying the Wires object’s handling of indices and dictionaries. Many methods, like__matmul__
, are greatly simplified.