Bump rich dependency to version 13
#512
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
**Context:** Old dependencies can hold back things which depend on the MrMustard, which can be very deep in the dependency tree. The `rich` package had a very old major version dependency (10.*.*) and this could interact with other seemingly random packages when depending on MrMustard. **Description of the Change:** Bump the major version of `rich` to 13. The only place I can see to test this version change is in the ProgressBar class, and this seemed to work fine for me on testing using the example code in the docs for using the optimizer. **Benefits:** Other packages that depend on MrMustard won't get into a tricky dependency situation with a very old package. **Possible Drawbacks:** Possible subtle bugs as this dependency doesn't appear to have unit tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #512 +/- ##
===========================================
- Coverage 89.85% 89.28% -0.57%
===========================================
Files 104 86 -18
Lines 7698 5956 -1742
===========================================
- Hits 6917 5318 -1599
+ Misses 781 638 -143 see 96 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
The issue with the code coverage checks seems to be changes in how docstrings and decorators are handled between versions of the "coverage" package. This changes the lock file and moves from coverage version 7.4.4 to 7.6.3. In the earlier version, docstrings and decorator executions are included, and the later version they are not. So there's a heap of stuff that appears to be less coverage, but these things aren't actual code in the codebase. (I can't merge this without all the checks being successful, including the code coverage ones.) |
|
i can't even find where/if this is configured. maybe there's a default value somewhere saying the max coverage delta must be <=0.15% or something like that? |
|
@timmysilv I think it was using code coverage's default values. I've added a .yml file that we can configure to (hopefully) fix this. |
Context: Old dependencies can hold back things which depend on the MrMustard, which can be very deep in the dependency tree. The
richpackage had a very old major version dependency (10..) and this could interact with other seemingly random packages when depending on MrMustard.Description of the Change: Bump the major version of
richto 13. The only place I can see to test this version change is in the ProgressBar class, and this seemed to work fine for me on testing using the example code in the docs for using the optimizer.Benefits: Other packages that depend on MrMustard won't get into a tricky dependency situation with a very old package.
Possible Drawbacks: Possible subtle bugs as this dependency doesn't appear to have unit tests.