Merge pull request #13 from bioodchao/master #17
XIELongDragonAnnotations
10 errors and 7 warnings
|
lint:
exp/ident.go#L48
emptyStringTest: replace `len(schema) > 0` with `schema != ""` (gocritic)
|
|
lint:
exp/ident.go#L52
emptyStringTest: replace `len(schema) > 0` with `schema != ""` (gocritic)
|
|
lint:
exp/ident.go#L56
emptyStringTest: replace `len(schema) > 0` with `schema != ""` (gocritic)
|
|
lint:
exp/ident.go#L55
emptyStringTest: replace `len(table) > 0` with `table != ""` (gocritic)
|
|
lint:
exp/record.go#L51
hugeParam: f is heavy (80 bytes); consider passing it by pointer (gocritic)
|
|
lint:
exp/record.go#L60
hugeParam: f is heavy (80 bytes); consider passing it by pointer (gocritic)
|
|
lint:
exp/window.go#L27
hugeParam: we is heavy (80 bytes); consider passing it by pointer (gocritic)
|
|
lint:
exp/window.go#L37
hugeParam: we is heavy (80 bytes); consider passing it by pointer (gocritic)
|
|
lint:
exp/window.go#L41
hugeParam: we is heavy (80 bytes); consider passing it by pointer (gocritic)
|
|
lint:
exec/query_executor.go#L34
hugeParam: q is heavy (88 bytes); consider passing it by pointer (gocritic)
|
|
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v4, golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
lint:
exp/record.go#L65
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
|
|
lint:
dialect/postgres/postgres_test.go#L163
unused-parameter: parameter 'entry' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
dialect/postgres/postgres_test.go#L215
unused-parameter: parameter 'entry' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
issues_test.go#L50
unused-parameter: parameter 'col' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
select_dataset_example_test.go#L70
var-naming: var userIds should be userIDs (revive)
|
|
lint:
dialect/sqlite3/sqlite3_test.go#L197
unused-parameter: parameter 'entry' seems to be unused, consider removing or renaming it as _ (revive)
|