use mongo downloader in utilix #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dachengx
approved these changes
Oct 11, 2024
Pull Request Test Coverage Report for Build 11296814121Details
💛 - Coveralls |
|
@dachengx Thanks.I double-checked that there's no remaining |
zihaoxu98
approved these changes
Oct 11, 2024
dachengx
approved these changes
Oct 12, 2024
dachengx
reviewed
Oct 12, 2024
| @@ -38,7 +38,6 @@ pandas = "*" | |||
| scikit-learn = "*" | |||
| scipy = "*" | |||
| strax = "*" | |||
| straxen = "*" | |||
| graphviz = "*" | |||
There was a problem hiding this comment.
Please add utilix = ">=0.10.1" here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed and implemented here: XENONnT/utilix#141
We propose to move the DB-related operations to
utilixto reducestraxendependency, as importingstraxenusually takes some time