WIP: try to use quote
+ prettyplease
#132
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a POC (which may be extended upon) to use
quote
+prettyplease
for code generation instead of a string.limitations i have found while using quote + syn + prettyplease:
/** */
if multilineaside from those problems there are some things which could be done, but i have not done yet:
buffer
is required (cannot add a beginningimpl
and a endimpl
like a string)syn::parse
)re #105
PS: i know the tests are failing, i have just included 2 updated test cases which cover the all the cases this PR touches, and to simplify a quick review
my personal opinion is that at least in the current state (see limitations), the string representation is a lot better; but we should maybe still store proc-macro2 / syn types in things like
StructField
or names, to maybe ensure they are valid idents and stuff