Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#280: workaround wrong order of optional/nullable parameters #294

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

#280: workaround wrong order of optional/nullable parameters #294

wants to merge 2 commits into from

Conversation

superbiche
Copy link

Fixes #280

tbreuss
tbreuss approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@tbreuss tbreuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mikaelcom
Copy link
Member

@superbiche You need to update the genereted files used for tests.
The simpliest way is to:

  1. uncomment line https://github.com/WsdlToPhp/PackageGenerator/blob/develop/tests/File/AbstractFile.php#L56
  2. launch locally phpunit on tests/File/StructTest.php
  3. comment back line https://github.com/WsdlToPhp/PackageGenerator/blob/develop/tests/File/AbstractFile.php#L56
  4. commit and push the updated files

Thx

@superbiche
Copy link
Author

Done (sorry for the time warp). Anything else to do ?

@superbiche
Copy link
Author

Rebased onto develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbreuss tbreuss tbreuss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional parameters before required ones in constructor
3 participants
@superbiche @mikaelcom @tbreuss